safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:27:50 +0100
changeset 50580 f30ce3558c2b
parent 50579 b08aed45ef00
child 50581 35b274cba81d
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/hgweb/webutil.py
--- a/mercurial/hgweb/webutil.py	Thu Feb 02 17:27:43 2023 +0100
+++ b/mercurial/hgweb/webutil.py	Thu Feb 02 17:27:50 2023 +0100
@@ -211,7 +211,7 @@
             b'description': s.description(),
             b'branch': s.branch(),
         }
-        if util.safehasattr(s, b'path'):
+        if util.safehasattr(s, 'path'):
             d[b'file'] = s.path()
         yield d