Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:27:43 +0100
changeset 50579 b08aed45ef00
parent 50578 eb49f8fb11d8
child 50580 f30ce3558c2b
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/hgweb/server.py file | annotate | diff | comparison | revisions 
--- a/mercurial/hgweb/server.py	Thu Feb 02 17:27:33 2023 +0100
+++ b/mercurial/hgweb/server.py	Thu Feb 02 17:27:43 2023 +0100
@@ -344,7 +344,7 @@
     threading.active_count()  # silence pyflakes and bypass demandimport
     _mixin = socketserver.ThreadingMixIn
 except ImportError:
-    if util.safehasattr(os, b"fork"):
+    if util.safehasattr(os, "fork"):
         _mixin = socketserver.ForkingMixIn
     else:
mercurial