Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:27:58 +0100
changeset 50581 35b274cba81d
parent 50580 f30ce3558c2b
child 50582 b23b3ef38ba1
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/httppeer.py file | annotate | diff | comparison | revisions 
--- a/mercurial/httppeer.py	Thu Feb 02 17:27:50 2023 +0100
+++ b/mercurial/httppeer.py	Thu Feb 02 17:27:58 2023 +0100
@@ -65,7 +65,7 @@
 class _multifile:
     def __init__(self, *fileobjs):
         for f in fileobjs:
-            if not util.safehasattr(f, b'length'):
+            if not util.safehasattr(f, 'length'):
                 raise ValueError(
                     b'_multifile only supports file objects that '
                     b'have a length but this one does not:',
mercurial