net.connect: Fix accumulation of connection attempt references
authorKim Alvefur <zash@zash.se>
Wed, 20 Apr 2022 22:41:54 +0200
changeset 12472 353836684009
parent 12471 ccbdebb43e23
child 12473 2b3adaa6d38e
net.connect: Fix accumulation of connection attempt references Connection attempts that failed the Happy Eyeballs race were not unreferenced and would accumulate. Tested by inspecting the 'pending_connections_map' after establishing s2s with a s2s target where the IPv6 port has a -j DROP rule causing it to time out and the IPv4 attempt wins the race. Expected is that the losing connection stays around until net.server timeouts kick in where it should be removed. The map table should tend towards being empty during idle times.
net/connect.lua
--- a/net/connect.lua	Wed Apr 13 18:46:26 2022 +0100
+++ b/net/connect.lua	Wed Apr 20 22:41:54 2022 +0200
@@ -91,6 +91,7 @@
 		return;
 	end
 	p.conns[conn] = nil;
+	pending_connections_map[conn] = nil;
 	p.last_error = reason or "unknown reason";
 	p:log("debug", "Connection attempt failed: %s", p.last_error);
 	if p.connected then