Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: drop ban of BaseException
authorPierre-Yves David <pierre-yves.david@fb.com>
Mon, 18 May 2015 13:20:19 -0500
changeset 25180 3ff2a5dc7c20
parent 25179 6dbbb4fa1892
child 25181 d26703eb3dc5
check-code: drop ban of BaseException Lets go back to the basic. It is available in Python 2.6.
contrib/check-code.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Mon May 18 13:25:07 2015 -0500
+++ b/contrib/check-code.py	Mon May 18 13:20:19 2015 -0500
@@ -269,7 +269,6 @@
      'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
     (r'opener\([^)]*\).read\(',
      "use opener.read() instead"),
-    (r'BaseException', 'not in Python 2.4, use Exception'),
     (r'opener\([^)]*\).write\(',
      "use opener.write() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',
mercurial