# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1431973219 18000
# Node ID 3ff2a5dc7c20568f07016abdb8a5156e5b56366d
# Parent  6dbbb4fa1892558229050c49fb738fd609a48b7f
check-code: drop ban of BaseException

Lets go back to the basic. It is available in Python 2.6.

diff -r 6dbbb4fa1892 -r 3ff2a5dc7c20 contrib/check-code.py
--- a/contrib/check-code.py	Mon May 18 13:25:07 2015 -0500
+++ b/contrib/check-code.py	Mon May 18 13:20:19 2015 -0500
@@ -269,7 +269,6 @@
      'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
     (r'opener\([^)]*\).read\(',
      "use opener.read() instead"),
-    (r'BaseException', 'not in Python 2.4, use Exception'),
     (r'opener\([^)]*\).write\(',
      "use opener.write() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',