Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
commit: change default `editor` parameter to None
authorMatt Harbison <matt_harbison@yahoo.com>
Sat, 28 Dec 2019 02:02:34 -0500
changeset 44023 3216cabffd4a
parent 44022 c1ccefb513e4
child 44024 a1ee825fc6c5
commit: change default `editor` parameter to None Flagged by PyCharm as a boolean not being callable later where it is used. There's no actual bug here because of `if editor` checks before using. Differential Revision: https://phab.mercurial-scm.org/D7768
mercurial/context.py file | annotate | diff | comparison | revisions
mercurial/localrepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/context.py	Sat Dec 28 01:51:17 2019 -0500
+++ b/mercurial/context.py	Sat Dec 28 02:02:34 2019 -0500
@@ -2738,7 +2738,7 @@
         date=None,
         extra=None,
         branch=None,
-        editor=False,
+        editor=None,
     ):
         super(memctx, self).__init__(
             repo, text, user, date, extra, branch=branch
@@ -2899,7 +2899,7 @@
         user=None,
         date=None,
         extra=None,
-        editor=False,
+        editor=None,
     ):
         if text is None:
             text = originalctx.description()
--- a/mercurial/localrepo.py	Sat Dec 28 01:51:17 2019 -0500
+++ b/mercurial/localrepo.py	Sat Dec 28 02:02:34 2019 -0500
@@ -2845,7 +2845,7 @@
         date=None,
         match=None,
         force=False,
-        editor=False,
+        editor=None,
         extra=None,
     ):
         """Add a new revision to current repository.
mercurial