# HG changeset patch # User Matt Harbison # Date 1577516554 18000 # Node ID 3216cabffd4ad7dba54b5029009c0e74c0fb383d # Parent c1ccefb513e4857bf371dab54ba569be0f0a9f06 commit: change default `editor` parameter to None Flagged by PyCharm as a boolean not being callable later where it is used. There's no actual bug here because of `if editor` checks before using. Differential Revision: https://phab.mercurial-scm.org/D7768 diff -r c1ccefb513e4 -r 3216cabffd4a mercurial/context.py --- a/mercurial/context.py Sat Dec 28 01:51:17 2019 -0500 +++ b/mercurial/context.py Sat Dec 28 02:02:34 2019 -0500 @@ -2738,7 +2738,7 @@ date=None, extra=None, branch=None, - editor=False, + editor=None, ): super(memctx, self).__init__( repo, text, user, date, extra, branch=branch @@ -2899,7 +2899,7 @@ user=None, date=None, extra=None, - editor=False, + editor=None, ): if text is None: text = originalctx.description() diff -r c1ccefb513e4 -r 3216cabffd4a mercurial/localrepo.py --- a/mercurial/localrepo.py Sat Dec 28 01:51:17 2019 -0500 +++ b/mercurial/localrepo.py Sat Dec 28 02:02:34 2019 -0500 @@ -2845,7 +2845,7 @@ date=None, match=None, force=False, - editor=False, + editor=None, extra=None, ): """Add a new revision to current repository.