#require serve zstd

Client version is embedded in HTTP request and is effectively dynamic. Pin the

version so behavior is deterministic.

  $ cat > fakeversion.py << EOF

  > from mercurial import util

  > util.version = lambda: b'4.2'

  > EOF

  $ cat >> $HGRCPATH << EOF

  > [extensions]

  > fakeversion = `pwd`/fakeversion.py

  > [format]

  > sparse-revlog = no

  > use-persistent-nodemap = no

  > [devel]

  > legacy.exchange = phases

  > [server]

  > concurrent-push-mode = strict

  > EOF

  $ hg init server0

  $ cd server0

  $ touch foo

  $ hg -q commit -A -m initial

Also disable compression because zstd is optional and causes output to vary

and because debugging partial responses is hard when compression is involved

  $ cat > .hg/hgrc << EOF

  > [extensions]

  > badserver = $TESTDIR/testlib/badserverext.py

  > [server]

  > compressionengines = none

  > EOF

Failure to accept() socket should result in connection related error message

----------------------------------------------------------------------------

  $ hg serve --config badserver.close-before-accept=true -p $HGPORT -d --pid-file=hg.pid

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: (\$ECONNRESET\$|\$EADDRNOTAVAIL\$) (re)

  [100]

(The server exits on its own, but there is a race between that and starting a new server.

So ensure the process is dead.)

  $ killdaemons.py $DAEMON_PIDS

Failure immediately after accept() should yield connection related error message

--------------------------------------------------------------------------------

  $ hg serve --config badserver.close-after-accept=true -p $HGPORT -d --pid-file=hg.pid

  $ cat hg.pid > $DAEMON_PIDS

TODO: this usually outputs good results, but sometimes emits abort:

error: '' on FreeBSD and OS X.

What we ideally want are:

abort: error: $ECONNRESET$

The flakiness in this output was observable easily with

--runs-per-test=20 on macOS 10.12 during the freeze for 4.2.

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

Failure to read all bytes in initial HTTP request should yield connection related error message

-----------------------------------------------------------------------------------------------

  $ hg serve --config badserver.close-after-recv-bytes=1 -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(1 from ~) -> (1) G

  read limit reached; closing socket

  $ rm -f error.log

Same failure, but server reads full HTTP request line

-----------------------------------------------------

  $ hg serve --config badserver.close-after-recv-bytes=40 -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(40 from ~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(7 from *) -> (7) Accept- (glob)

  read limit reached; closing socket

  $ rm -f error.log

Failure on subsequent HTTP request on the same socket (cmd?batch)

-----------------------------------------------------------------

  $ hg serve --config badserver.close-after-recv-bytes=210,223 -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(210 from ~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(177 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(150 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(115 from *) -> (*) host: localhost:$HGPORT\r\n (glob)

  readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(* from *) -> (2) \r\n (glob)

  sendall(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\n (py36 !)

  sendall(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py36 !)

  write(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\n (py3 no-py36 !)

  write(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py3 no-py36 !)

  write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !)

  write(23) -> Server: badhttpserver\r\n (no-py3 !)

  write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !)

  write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !)

  write(21) -> Content-Length: 431\r\n (no-py3 !)

  write(2) -> \r\n (no-py3 !)

  write(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (no-py3 !)

  readline(4? from ~) -> (26) GET /?cmd=batch HTTP/1.1\r\n (glob)

  readline(1? from *) -> (1?) Accept-Encoding* (glob)

  read limit reached; closing socket

  readline(223 from ~) -> (26) GET /?cmd=batch HTTP/1.1\r\n

  readline(197 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(170 from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)

  readline(141 from *) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n (glob)

  readline(100 from *) -> (61) x-hgproto-1: 0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull\r\n (glob)

  readline(39 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(4 from *) -> (4) host (glob)

  read limit reached; closing socket

  $ rm -f error.log

Failure to read getbundle HTTP request

--------------------------------------

  $ hg serve --config badserver.close-after-recv-bytes=308,317,304 -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  requesting all changes

  abort: error: bad HTTP status line: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(1 from -1) -> (1) x (?)

  readline(1 from -1) -> (1) x (?)

  readline(308 from ~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(275 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(248 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(213 from *) -> (*) host: localhost:$HGPORT\r\n (glob)

  readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(* from *) -> (2) \r\n (glob)

  sendall(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\n (py36 !)

  sendall(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py36 !)

  write(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\n (py3 no-py36 !)

  write(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py3 no-py36 !)

  write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !)

  write(23) -> Server: badhttpserver\r\n (no-py3 !)

  write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !)

  write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !)

  write(21) -> Content-Length: 431\r\n (no-py3 !)

  write(2) -> \r\n (no-py3 !)

  write(431) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (no-py3 !)

  readline(13? from ~) -> (26) GET /?cmd=batch HTTP/1.1\r\n (glob)

  readline(1?? from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(8? from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)

  readline(5? from *) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n (glob)

  readline(1? from *) -> (1?) x-hgproto-1:* (glob)

  read limit reached; closing socket

  readline(317 from ~) -> (26) GET /?cmd=batch HTTP/1.1\r\n

  readline(291 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(264 from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)

  readline(235 from *) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n (glob)

  readline(194 from *) -> (61) x-hgproto-1: 0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull\r\n (glob)

  readline(133 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(98 from *) -> (*) host: localhost:$HGPORT\r\n (glob)

  readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(* from *) -> (2) \r\n (glob)

  sendall(159) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 42\r\n\r\n (py36 !)

  sendall(42) -> 96ee1d7354c4ad7372047672c36a1f561e3a6a4c\n; (py36 !)

  write(159) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 42\r\n\r\n (py3 no-py36 !)

  write(42) -> 96ee1d7354c4ad7372047672c36a1f561e3a6a4c\n; (py3 no-py36 !)

  write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !)

  write(23) -> Server: badhttpserver\r\n (no-py3 !)

  write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !)

  write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !)

  write(20) -> Content-Length: 42\r\n (no-py3 !)

  write(2) -> \r\n (no-py3 !)

  write(42) -> 96ee1d7354c4ad7372047672c36a1f561e3a6a4c\n; (no-py3 !)

  readline(* from ~) -> (*) GET /?cmd=getbundle HTTP* (glob)

  read limit reached; closing socket

  readline(304 from ~) -> (30) GET /?cmd=getbundle HTTP/1.1\r\n

  readline(274 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(247 from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)

  readline(218 from *) -> (218) x-hgarg-1: bookmarks=1&bundlecaps=HG20%2Cbundle2%3DHG20%250Abookmarks%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtag (glob)

  read limit reached; closing socket

  $ rm -f error.log

Now do a variation using POST to send arguments

===============================================

  $ hg serve --config experimental.httppostargs=true --config badserver.close-after-recv-bytes=329,344 -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: * (glob)

  [100]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log | "$PYTHON" $TESTDIR/filtertraceback.py

  readline(329 from ~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(296 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(269 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(234 from *) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(* from *) -> (2) \r\n (glob)

  sendall(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py36 !)

  sendall(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py36 !)

  write(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py3 no-py36 !)

  write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py3 no-py36 !)

  write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !)

  write(23) -> Server: badhttpserver\r\n (no-py3 !)

  write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !)

  write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !)

  write(21) -> Content-Length: 444\r\n (no-py3 !)

  write(2) -> \r\n (no-py3 !)

  write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (no-py3 !)

  readline(1?? from ~) -> (27) POST /?cmd=batch HTTP/1.1\r\n (glob)

  readline(1?? from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(1?? from *) -> (41) content-type: application/mercurial-0.1\r\n (glob)

  readline(6? from *) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob)

  readline(3? from *) -> (19) x-hgargs-post: 28\r\n (glob)

  readline(1? from *) -> (1?) x-hgproto-1: * (glob)

  read limit reached; closing socket

  readline(344 from ~) -> (27) POST /?cmd=batch HTTP/1.1\r\n

  readline(317 from *) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(290 from *) -> (41) content-type: application/mercurial-0.1\r\n (glob)

  readline(249 from *) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob)

  readline(216 from *) -> (19) x-hgargs-post: 28\r\n (glob)

  readline(197 from *) -> (61) x-hgproto-1: 0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull\r\n (glob)

  readline(136 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)

  readline(101 from *) -> (20) content-length: 28\r\n (glob)