#require killdaemons serve zstd

Client version is embedded in HTTP request and is effectively dynamic. Pin the

version so behavior is deterministic.

  $ cat > fakeversion.py << EOF

  > from mercurial import util

  > util.version = lambda: '4.2'

  > EOF

  $ cat >> $HGRCPATH << EOF

  > [extensions]

  > fakeversion = `pwd`/fakeversion.py

  > EOF

  $ hg init server0

  $ cd server0

  $ touch foo

  $ hg -q commit -A -m initial

Also disable compression because zstd is optional and causes output to vary

and because debugging partial responses is hard when compression is involved

  $ cat > .hg/hgrc << EOF

  > [extensions]

  > badserver = $TESTDIR/badserverext.py

  > [server]

  > compressionengines = none

  > EOF

Failure to accept() socket should result in connection related error message

  $ hg --config badserver.closebeforeaccept=true serve -p $HGPORT -d --pid-file=hg.pid

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: Connection reset by peer (no-windows !)

  abort: error: An existing connection was forcibly closed by the remote host (windows !)

  [255]

(The server exits on its own, but there is a race between that and starting a new server.

So ensure the process is dead.)

  $ killdaemons.py $DAEMON_PIDS

Failure immediately after accept() should yield connection related error message

  $ hg --config badserver.closeafteraccept=true serve -p $HGPORT -d --pid-file=hg.pid

  $ cat hg.pid > $DAEMON_PIDS

TODO: this usually outputs good results, but sometimes emits abort:

error: '' on FreeBSD and OS X.

What we ideally want are:

abort: error: Connection reset by peer (no-windows !)

abort: error: An existing connection was forcibly closed by the remote host (windows !)

The flakiness in this output was observable easily with

--runs-per-test=20 on macOS 10.12 during the freeze for 4.2.

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: * (glob)

  [255]

  $ killdaemons.py $DAEMON_PIDS

Failure to read all bytes in initial HTTP request should yield connection related error message

  $ hg --config badserver.closeafterrecvbytes=1 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: ''

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(1 from 65537) -> (1) G

  read limit reached; closing socket

  $ rm -f error.log

Same failure, but server reads full HTTP request line

  $ hg --config badserver.closeafterrecvbytes=40 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: ''

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(40 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(7 from -1) -> (7) Accept-

  read limit reached; closing socket

  $ rm -f error.log

Failure on subsequent HTTP request on the same socket (cmd?batch)

  $ hg --config badserver.closeafterrecvbytes=210 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: ''

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(210 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(177 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(150 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(115 from -1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(9? from -1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(4? from -1) -> (2) \r\n (glob)

  write(36) -> HTTP/1.1 200 Script output follows\r\n

  write(23) -> Server: badhttpserver\r\n

  write(37) -> Date: Fri, 14 Apr 2017 00:00:00 GMT\r\n

  write(41) -> Content-Type: application/mercurial-0.1\r\n

  write(21) -> Content-Length: 405\r\n

  write(2) -> \r\n

  write(405) -> lookup changegroupsubset branchmap pushkey known getbundle unbundlehash batch streamreqs=generaldelta,revlogv1 bundle2=HG20%0Achangegroup%3D01%2C02%0Adigests%3Dmd5%2Csha1%2Csha512%0Aerror%3Dabort%2Cunsupportedcontent%2Cpushraced%2Cpushkey%0Ahgtagsfnodes%0Alistkeys%0Apushkey%0Aremote-changegroup%3Dhttp%2Chttps unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx compression=none

  readline(4? from 65537) -> (26) GET /?cmd=batch HTTP/1.1\r\n (glob)

  readline(1? from -1) -> (1?) Accept-Encoding* (glob)

  read limit reached; closing socket

  readline(210 from 65537) -> (26) GET /?cmd=batch HTTP/1.1\r\n

  readline(184 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(157 from -1) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n

  readline(128 from -1) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n

  readline(87 from -1) -> (48) x-hgproto-1: 0.1 0.2 comp=zstd,zlib,none,bzip2\r\n

  readline(39 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(4 from -1) -> (4) host

  read limit reached; closing socket

  $ rm -f error.log

Failure to read getbundle HTTP request

  $ hg --config badserver.closeafterrecvbytes=292 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  requesting all changes

  abort: error: bad HTTP status line: ''

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(292 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(259 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(232 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(197 from -1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(17? from -1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(12? from -1) -> (2) \r\n (glob)

  write(36) -> HTTP/1.1 200 Script output follows\r\n

  write(23) -> Server: badhttpserver\r\n

  write(37) -> Date: Fri, 14 Apr 2017 00:00:00 GMT\r\n

  write(41) -> Content-Type: application/mercurial-0.1\r\n

  write(21) -> Content-Length: 405\r\n

  write(2) -> \r\n

  write(405) -> lookup changegroupsubset branchmap pushkey known getbundle unbundlehash batch streamreqs=generaldelta,revlogv1 bundle2=HG20%0Achangegroup%3D01%2C02%0Adigests%3Dmd5%2Csha1%2Csha512%0Aerror%3Dabort%2Cunsupportedcontent%2Cpushraced%2Cpushkey%0Ahgtagsfnodes%0Alistkeys%0Apushkey%0Aremote-changegroup%3Dhttp%2Chttps unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx compression=none

  readline\(12[34] from 65537\) -> \(2[67]\) GET /\?cmd=batch HTTP/1.1\\r\\n (re)

  readline(9? from -1) -> (27) Accept-Encoding: identity\r\n (glob)

  readline(7? from -1) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)

  readline(4? from -1) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n (glob)

  readline(1 from -1) -> (1) x (?)

  read limit reached; closing socket

  readline(292 from 65537) -> (26) GET /?cmd=batch HTTP/1.1\r\n

  readline(266 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(239 from -1) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n

  readline(210 from -1) -> (41) x-hgarg-1: cmds=heads+%3Bknown+nodes%3D\r\n

  readline(169 from -1) -> (48) x-hgproto-1: 0.1 0.2 comp=zstd,zlib,none,bzip2\r\n

  readline(121 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(86 from -1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(6? from -1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(1? from -1) -> (2) \r\n (glob)

  write(36) -> HTTP/1.1 200 Script output follows\r\n

  write(23) -> Server: badhttpserver\r\n

  write(37) -> Date: Fri, 14 Apr 2017 00:00:00 GMT\r\n

  write(41) -> Content-Type: application/mercurial-0.1\r\n

  write(20) -> Content-Length: 42\r\n

  write(2) -> \r\n

  write(42) -> 96ee1d7354c4ad7372047672c36a1f561e3a6a4c\n;

  readline\(1[23] from 65537\) -> \(1[23]\) GET /\?cmd=ge.? (re)

  read limit reached; closing socket

  readline(292 from 65537) -> (30) GET /?cmd=getbundle HTTP/1.1\r\n

  readline(262 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(235 from -1) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n

  readline(206 from -1) -> (206) x-hgarg-1: bundlecaps=HG20%2Cbundle2%3DHG20%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtagsfnodes%250Ali

  read limit reached; closing socket

  $ rm -f error.log

Now do a variation using POST to send arguments

  $ hg --config experimental.httppostargs=true --config badserver.closeafterrecvbytes=315 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: ''

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(315 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(282 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(255 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(220 from -1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(19? from -1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(14? from -1) -> (2) \r\n (glob)

  write(36) -> HTTP/1.1 200 Script output follows\r\n

  write(23) -> Server: badhttpserver\r\n

  write(37) -> Date: Fri, 14 Apr 2017 00:00:00 GMT\r\n

  write(41) -> Content-Type: application/mercurial-0.1\r\n

  write(21) -> Content-Length: 418\r\n

  write(2) -> \r\n

  write(418) -> lookup changegroupsubset branchmap pushkey known getbundle unbundlehash batch streamreqs=generaldelta,revlogv1 bundle2=HG20%0Achangegroup%3D01%2C02%0Adigests%3Dmd5%2Csha1%2Csha512%0Aerror%3Dabort%2Cunsupportedcontent%2Cpushraced%2Cpushkey%0Ahgtagsfnodes%0Alistkeys%0Apushkey%0Aremote-changegroup%3Dhttp%2Chttps unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 httppostargs httpmediatype=0.1rx,0.1tx,0.2tx compression=none

  readline\(14[67] from 65537\) -> \(2[67]\) POST /\?cmd=batch HTTP/1.1\\r\\n (re)

  readline\(1(19|20) from -1\) -> \(27\) Accept-Encoding: identity\\r\\n (re)

  readline(9? from -1) -> (41) content-type: application/mercurial-0.1\r\n (glob)

  readline(5? from -1) -> (19) vary: X-HgProto-1\r\n (glob)

  readline(3? from -1) -> (19) x-hgargs-post: 28\r\n (glob)

  readline(1? from -1) -> (1?) x-hgproto-1: * (glob)

  read limit reached; closing socket

  readline(315 from 65537) -> (27) POST /?cmd=batch HTTP/1.1\r\n

  readline(288 from -1) -> (27) Accept-Encoding: identity\r\n

  readline(261 from -1) -> (41) content-type: application/mercurial-0.1\r\n

  readline(220 from -1) -> (19) vary: X-HgProto-1\r\n

  readline(201 from -1) -> (19) x-hgargs-post: 28\r\n

  readline(182 from -1) -> (48) x-hgproto-1: 0.1 0.2 comp=zstd,zlib,none,bzip2\r\n

  readline(134 from -1) -> (35) accept: application/mercurial-0.1\r\n

  readline(99 from -1) -> (20) content-length: 28\r\n

  readline(79 from -1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(5? from -1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)

  readline(? from -1) -> (2) \r\n (glob)

  read(? from 28) -> (?) cmds=* (glob)

  read limit reached, closing socket

  write(36) -> HTTP/1.1 500 Internal Server Error\r\n

  $ rm -f error.log

Now move on to partial server responses

Server sends a single character from the HTTP response line

  $ hg --config badserver.closeaftersendbytes=1 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: error: bad HTTP status line: H

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(-1) -> (27) Accept-Encoding: identity\r\n

  readline(-1) -> (35) accept: application/mercurial-0.1\r\n

  readline(-1) -> (2?) host: localhost:$HGPORT\r\n (glob)

  readline(-1) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n

  readline(-1) -> (2) \r\n

  write(1 from 36) -> (0) H

  write limit reached; closing socket

  write(36) -> HTTP/1.1 500 Internal Server Error\r\n

  $ rm -f error.log

Server sends an incomplete capabilities response body

  $ hg --config badserver.closeaftersendbytes=180 serve -p $HGPORT -d --pid-file=hg.pid -E error.log

  $ cat hg.pid > $DAEMON_PIDS

  $ hg clone http://localhost:$HGPORT/ clone

  abort: HTTP request error (incomplete response; expected 385 bytes got 20)

  (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)

  [255]

  $ killdaemons.py $DAEMON_PIDS

  $ cat error.log

  readline(65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n

  readline(-1) -> (27) Accept-Encoding: identity\r\n

  readline(-1) -> (35) accept: application/mercurial-0.1\r\n