mod_smacks: Use new pre-session-close event instead of monkeypatch
authorKim Alvefur <zash@zash.se>
Wed, 01 Dec 2021 15:09:11 +0100
changeset 11979 fcea4d9e7502
parent 11978 a7c183bb4e64
child 11980 10cdfb94f1cc
mod_smacks: Use new pre-session-close event instead of monkeypatch Much cleaner.
plugins/mod_smacks.lua
--- a/plugins/mod_smacks.lua	Wed Dec 01 15:06:48 2021 +0100
+++ b/plugins/mod_smacks.lua	Wed Dec 01 15:09:11 2021 +0100
@@ -256,22 +256,25 @@
 
 	add_filter(session, "stanzas/out", outgoing_stanza_filter, -999);
 
-	local session_close = session.close;
-	function session.close(...)
-		if session.resumption_token then
-			session_registry.set(session.username, session.resumption_token, nil);
-			old_session_registry.set(session.username, session.resumption_token, nil);
-			session.resumption_token = nil;
-		end
-		-- send out last ack as per revision 1.5.2 of XEP-0198
-		if session.smacks and session.conn and session.handled_stanza_count then
-			(session.sends2s or session.send)(st.stanza("a", { xmlns = session.smacks, h = string.format("%d", session.handled_stanza_count) }));
-		end
-		return session_close(...);
-	end
 	return session;
 end
 
+module:hook("pre-session-close", function(event)
+	local session = event.session;
+	if session.resumption_token then
+		session_registry.set(session.username, session.resumption_token, nil);
+		old_session_registry.set(session.username, session.resumption_token, nil);
+		session.resumption_token = nil;
+	end
+	-- send out last ack as per revision 1.5.2 of XEP-0198
+	if session.smacks and session.conn and session.handled_stanza_count then
+		(session.sends2s or session.send)(st.stanza("a", {
+			xmlns = session.smacks;
+			h = string.format("%d", session.handled_stanza_count);
+		}));
+	end
+end);
+
 local function wrap_session_in(session, resume)
 	if not resume then
 		session.handled_stanza_count = 0;