mod_external_services: Move error message to correct place (fix #1725) 0.12
authorKim Alvefur <zash@zash.se>
Wed, 23 Mar 2022 15:29:01 +0100
branch0.12
changeset 12435 95f33a006c03
parent 12431 018ac691ee22
child 12436 60eecdd9c65b
child 12437 3dfcdcab5446
mod_external_services: Move error message to correct place (fix #1725) This message was misplaced in c4599a7c534c when the @type and @host check was introduced.
plugins/mod_external_services.lua
--- a/plugins/mod_external_services.lua	Mon Mar 21 12:36:20 2022 +0000
+++ b/plugins/mod_external_services.lua	Wed Mar 23 15:29:01 2022 +0100
@@ -192,7 +192,7 @@
 	local action = stanza.tags[1];
 
 	if origin.type ~= "c2s" then
-		origin.send(st.error_reply(stanza, "auth", "forbidden", "The 'port' and 'type' attributes are required."));
+		origin.send(st.error_reply(stanza, "auth", "forbidden"));
 		return true;
 	end
 
@@ -204,7 +204,7 @@
 	local requested_credentials = set.new();
 	for service in action:childtags("service") do
 		if not service.attr.type or not service.attr.host then
-			origin.send(st.error_reply(stanza, "modify", "bad-request"));
+			origin.send(st.error_reply(stanza, "modify", "bad-request", "The 'port' and 'type' attributes are required."));
 			return true;
 		end