net.resolvers.basic: Disable DANE for now, completely broken
authorKim Alvefur <zash@zash.se>
Wed, 03 Mar 2021 20:48:54 +0100
changeset 11425 926d53af9a7a
parent 11424 f768db80aee0
child 11426 fa5a23d7aabc
net.resolvers.basic: Disable DANE for now, completely broken Turns out 'extra' is, at least for mod_s2s, the same table for *all* connections.
CHANGES
net/resolvers/basic.lua
--- a/CHANGES	Wed Mar 03 18:42:54 2021 +0100
+++ b/CHANGES	Wed Mar 03 20:48:54 2021 +0100
@@ -17,7 +17,6 @@
 -   `daemonize` option deprecated
 -   SASL DIGEST-MD5 removed
 -   Switch to libunbound for DNS queries
--   DANE Support
 -   mod_external_services (XEP-0215)
 -   util.error for encapsulating errors
 -   MUC: support for XEP-0421 occupant identifiers
--- a/net/resolvers/basic.lua	Wed Mar 03 18:42:54 2021 +0100
+++ b/net/resolvers/basic.lua	Wed Mar 03 20:48:54 2021 +0100
@@ -36,15 +36,14 @@
 		n = n - 1;
 		if n > 0 then return; end
 		self.targets = targets;
+		--[[
+		-- TODO stash tlsa somewhere per connection
+		-- FIXME 'extra' here is not per connection
 		if self.extra and self.extra.use_dane then
 			if secure and tlsa[1] then
-				self.extra.tlsa = tlsa;
-				self.extra.dane_hostname = self.hostname;
-			else
-				self.extra.tlsa = nil;
-				self.extra.dane_hostname = nil;
 			end
 		end
+		--]]
 		self:next(cb);
 	end