Mercurial Mercurial > prosody > prosody / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
openmetrics/histograms: improve code clarity
authorKim Alvefur <zash@zash.se>
Mon, 27 Dec 2021 16:05:12 +0100
changeset 12128 7d985e5bc1fb
parent 12127 7ba686696250
child 12129 649268c9f603
openmetrics/histograms: improve code clarity If buckets thresholds are to be taken as "less than or equal to", then using the less than or equal to operator seems sensible.
util/statistics.lua file | annotate | diff | comparison | revisions
util/statsd.lua file | annotate | diff | comparison | revisions 
--- a/util/statistics.lua	Sun Dec 26 22:32:00 2021 +0100
+++ b/util/statistics.lua	Mon Dec 27 16:05:12 2021 +0100
@@ -102,7 +102,7 @@
 function histogram_metric_mt:sample(value)
 	-- According to the I-D, values must be part of all buckets
 	for i, bucket in pairs(self) do
-		if "number" == type(i) and bucket.threshold >= value then
+		if "number" == type(i) and value <= bucket.threshold then
 			bucket.count = bucket.count + 1
 		end
 	end
--- a/util/statsd.lua	Sun Dec 26 22:32:00 2021 +0100
+++ b/util/statsd.lua	Mon Dec 27 16:05:12 2021 +0100
@@ -115,7 +115,7 @@
 function histogram_metric_mt:sample(value)
 	-- According to the I-D, values must be part of all buckets
 	for i, bucket in pairs(self) do
-		if "number" == type(i) and bucket.threshold >= value then
+		if "number" == type(i) and value <= bucket.threshold then
 			bucket.count = bucket.count + 1
 			self._impl:push_counter_delta(bucket._full_name, 1)
 		end
prosody