mod_smacks: Change boolean attribute from '1' to 'true' for compatibility
authorMatthew Wild <mwild1@gmail.com>
Fri, 07 Oct 2022 11:35:56 +0100
changeset 12749 2cbf0e9314ff
parent 12748 e894677359e5
child 12750 7eabf8d78978
mod_smacks: Change boolean attribute from '1' to 'true' for compatibility Conversations 2.10.10 and earlier expect this to be literally 'true' and don't recognise '1'. This leads to it not attempting resumption with Prosody at all since this change was introduced in 36ba170c4fd0. Thanks to Zash for noticing, debugging and diagnosing this issue. This issue is fixed in Conversations commit 052c58f3 (unreleased at the time of writing).
plugins/mod_smacks.lua
--- a/plugins/mod_smacks.lua	Thu Oct 06 18:34:40 2022 +0100
+++ b/plugins/mod_smacks.lua	Fri Oct 07 11:35:56 2022 +0100
@@ -354,7 +354,7 @@
 	(session.sends2s or session.send)(st.stanza("enabled", {
 		xmlns = xmlns_sm;
 		id = enabled.id;
-		resume = enabled.id and "1" or nil;
+		resume = enabled.id and "true" or nil; -- COMPAT w/ Conversations 2.10.10 requires 'true' not '1'
 		max = enabled.resume_max;
 	}));