spec: Correct order of arguments to asserts in configmanager tests
authorKim Alvefur <zash@zash.se>
Sat, 11 Aug 2018 19:59:19 +0200
changeset 9171 29de7ad20250
parent 9170 7ed130d3676c
child 9172 3ec013185c15
spec: Correct order of arguments to asserts in configmanager tests assert.foo(expect, got, ...)
spec/core_configmanager_spec.lua
--- a/spec/core_configmanager_spec.lua	Sat Aug 11 17:22:26 2018 +0200
+++ b/spec/core_configmanager_spec.lua	Sat Aug 11 19:59:19 2018 +0200
@@ -5,27 +5,27 @@
 	describe("#get()", function()
 		it("should work", function()
 			configmanager.set("example.com", "testkey", 123);
-			assert.are.equal(configmanager.get("example.com", "testkey"), 123, "Retrieving a set key");
+			assert.are.equal(123, configmanager.get("example.com", "testkey"), "Retrieving a set key");
 
 			configmanager.set("*", "testkey1", 321);
-			assert.are.equal(configmanager.get("*", "testkey1"), 321, "Retrieving a set global key");
-			assert.are.equal(configmanager.get("example.com", "testkey1"), 321, "Retrieving a set key of undefined host, of which only a globally set one exists");
+			assert.are.equal(321, configmanager.get("*", "testkey1"), "Retrieving a set global key");
+			assert.are.equal(321, configmanager.get("example.com", "testkey1"), "Retrieving a set key of undefined host, of which only a globally set one exists");
 
 			configmanager.set("example.com", ""); -- Creates example.com host in config
-			assert.are.equal(configmanager.get("example.com", "testkey1"), 321, "Retrieving a set key, of which only a globally set one exists");
+			assert.are.equal(321, configmanager.get("example.com", "testkey1"), "Retrieving a set key, of which only a globally set one exists");
 
-			assert.are.equal(configmanager.get(), nil, "No parameters to get()");
-			assert.are.equal(configmanager.get("undefined host"), nil, "Getting for undefined host");
-			assert.are.equal(configmanager.get("undefined host", "undefined key"), nil, "Getting for undefined host & key");
+			assert.are.equal(nil, configmanager.get(), "No parameters to get()");
+			assert.are.equal(nil, configmanager.get("undefined host"), "Getting for undefined host");
+			assert.are.equal(nil, configmanager.get("undefined host", "undefined key"), "Getting for undefined host & key");
 		end);
 	end);
 
 	describe("#set()", function()
 		it("should work", function()
-			assert.are.equal(configmanager.set("*"), false, "Set with no key");
+			assert.are.equal(false, configmanager.set("*"), "Set with no key");
 
-			assert.are.equal(configmanager.set("*", "set_test", "testkey"), true, "Setting a nil global value");
-			assert.are.equal(configmanager.set("*", "set_test", "testkey", 123), true, "Setting a global value");
+			assert.are.equal(true, configmanager.set("*", "set_test", "testkey"), "Setting a nil global value");
+			assert.are.equal(true, configmanager.set("*", "set_test", "testkey", 123), "Setting a global value");
 		end);
 	end);
 end);