2004-01-29 Richard Hult <richard@imendio.com>
authorrhult <rhult>
Thu, 29 Jan 2004 10:01:43 +0000
changeset 79 63971f168ce6
parent 78 8506d9435c93
child 80 4563b74e333e
2004-01-29 Richard Hult <richard@imendio.com> * loudmouth/lm-message-node.c: (lm_message_node_to_string): * loudmouth/lm-message.c: (lm_message_new): (lm_message_new_with_sub_type), (lm_message_unref): - Plug leaks and fix two small coding style issues.
ChangeLog
loudmouth/lm-message-node.c
loudmouth/lm-message.c
--- a/ChangeLog	Fri Jan 23 05:29:37 2004 +0000
+++ b/ChangeLog	Thu Jan 29 10:01:43 2004 +0000
@@ -1,3 +1,10 @@
+2004-01-29  Richard Hult  <richard@imendio.com>
+
+	* loudmouth/lm-message-node.c: (lm_message_node_to_string):
+	* loudmouth/lm-message.c: (lm_message_new):
+	(lm_message_new_with_sub_type), (lm_message_unref): 
+	- Plug leaks and fix two small coding style issues.
+
 2004-01-23  Mikael Hallendal  <micke@imendio.com>
 	
 	* Release 0.15.1
--- a/loudmouth/lm-message-node.c	Fri Jan 23 05:29:37 2004 +0000
+++ b/loudmouth/lm-message-node.c	Thu Jan 29 10:01:43 2004 +0000
@@ -467,6 +467,7 @@
 		str = ret_val;
 		ret_val = g_strconcat (str, "  ", child_str, NULL);
 		g_free (str);
+		g_free (child_str);
 	}
 
 	str = ret_val;
--- a/loudmouth/lm-message.c	Fri Jan 23 05:29:37 2004 +0000
+++ b/loudmouth/lm-message.c	Thu Jan 29 10:01:43 2004 +0000
@@ -202,8 +202,10 @@
 LmMessage *
 lm_message_new (const gchar *to, LmMessageType type)
 {
-	LmMessage *m = g_new0 (LmMessage, 1);
-	
+	LmMessage *m;
+	gchar     *id;
+
+	m       = g_new0 (LmMessage, 1);
 	m->priv = g_new0 (LmMessagePriv, 1);
 
 	PRIV(m)->ref_count = 1;
@@ -212,7 +214,9 @@
 	
 	m->node = _lm_message_node_new (_lm_message_type_to_string (type));
 
-	lm_message_node_set_attribute (m->node, "id", _lm_utils_generate_id());
+	id = _lm_utils_generate_id ();
+	lm_message_node_set_attribute (m->node, "id", id);
+	g_free (id);
 	
 	if (to) {
 		lm_message_node_set_attribute (m->node, "to", to);
@@ -241,9 +245,11 @@
 			      LmMessageType     type, 
 			      LmMessageSubType  sub_type)
 {
-	LmMessage   *m = lm_message_new (to, type);
+	LmMessage   *m;
 	const gchar *type_str;
 
+	m = lm_message_new (to, type);
+
 	type_str = _lm_message_sub_type_to_string (sub_type);
 
 	if (type_str) {
@@ -337,6 +343,7 @@
 	
 	if (PRIV(message)->ref_count == 0) {
 		lm_message_node_unref (message->node);
+		g_free (message->priv);
 		g_free (message);
 	}
 }