Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
manifestrevlog: flag some inconsistency in bundle/union repo inheritance
authorPierre-Yves David <pierre-yves.david@octobus.net>
Tue, 10 Oct 2023 10:01:57 +0200
changeset 51028 f70ce1aedbcb
parent 51027 3314c41c3759
child 51029 498afb627f78
manifestrevlog: flag some inconsistency in bundle/union repo inheritance This "work" but still, this is weird, let us point it out.
mercurial/bundlerepo.py file | annotate | diff | comparison | revisions
mercurial/unionrepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/bundlerepo.py	Sat Sep 30 02:02:36 2023 +0200
+++ b/mercurial/bundlerepo.py	Tue Oct 10 10:01:57 2023 +0200
@@ -204,6 +204,8 @@
         dirlogstarts=None,
         dir=b'',
     ):
+        # XXX manifestrevlog is not actually a revlog , so mixing it with
+        # bundlerevlog is not a good idea.
         manifest.manifestrevlog.__init__(self, nodeconstants, opener, tree=dir)
         bundlerevlog.__init__(
             self,
--- a/mercurial/unionrepo.py	Sat Sep 30 02:02:36 2023 +0200
+++ b/mercurial/unionrepo.py	Tue Oct 10 10:01:57 2023 +0200
@@ -205,6 +205,8 @@
 
 class unionmanifest(unionrevlog, manifest.manifestrevlog):
     def __init__(self, nodeconstants, opener, opener2, linkmapper):
+        # XXX manifestrevlog is not actually a revlog , so mixing it with
+        # bundlerevlog is not a good idea.
         manifest.manifestrevlog.__init__(self, nodeconstants, opener)
         manifest2 = manifest.manifestrevlog(nodeconstants, opener2)
         unionrevlog.__init__(
mercurial