Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
packaging: set the FileVersion field in the Inno installer executable stable
authorMatt Harbison <matt_harbison@yahoo.com>
Sat, 01 Feb 2020 00:41:37 -0500
branchstable
changeset 44221 f37971c31067
parent 44220 a70108a3d7cc
child 44222 a8786727e478
packaging: set the FileVersion field in the Inno installer executable Previously, Properties > Details > File version showed "0.0.0.0". This appears to be a longstanding issue, and not part of the refactoring this cycle. Differential Revision: https://phab.mercurial-scm.org/D8060
contrib/packaging/hgpackaging/inno.py file | annotate | diff | comparison | revisions
contrib/packaging/inno/mercurial.iss file | annotate | diff | comparison | revisions 
--- a/contrib/packaging/hgpackaging/inno.py	Sat Feb 01 00:32:46 2020 -0500
+++ b/contrib/packaging/hgpackaging/inno.py	Sat Feb 01 00:41:37 2020 -0500
@@ -20,6 +20,7 @@
 )
 from .util import (
     find_vc_runtime_files,
+    normalize_windows_version,
     read_version_py,
 )
 
@@ -156,6 +157,7 @@
         version = read_version_py(source_dir)
 
     args.append('/dVERSION=%s' % version)
+    args.append('/dQUAD_VERSION=%s' % normalize_windows_version(version))
 
     args.append('/Odist')
     args.append(str(inno_build_dir / 'mercurial.iss'))
--- a/contrib/packaging/inno/mercurial.iss	Sat Feb 01 00:32:46 2020 -0500
+++ b/contrib/packaging/inno/mercurial.iss	Sat Feb 01 00:41:37 2020 -0500
@@ -32,6 +32,7 @@
 VersionInfoDescription=Mercurial distributed SCM (version {#VERSION})
 VersionInfoCopyright=Copyright 2005-2020 Matt Mackall and others
 VersionInfoCompany=Matt Mackall and others
+VersionInfoVersion={#QUAD_VERSION}
 InternalCompressLevel=max
 SolidCompression=true
 SetupIconFile=../mercurial.ico
mercurial