Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
push-dests: move the code around missing default dest inside `get_push_paths`
authorPierre-Yves David <pierre-yves.david@octobus.net>
Tue, 13 Apr 2021 15:30:32 +0200
changeset 46917 efadec3ea8e2
parent 46916 7061eee84151
child 46918 248cbe173203
push-dests: move the code around missing default dest inside `get_push_paths` This function has a clear semantic and moving the code dealing with this inside it will help reduce duplication. Differential Revision: https://phab.mercurial-scm.org/D10385
mercurial/commands.py file | annotate | diff | comparison | revisions
mercurial/utils/urlutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/commands.py	Tue Apr 13 15:32:59 2021 +0200
+++ b/mercurial/commands.py	Tue Apr 13 15:30:32 2021 +0200
@@ -5703,11 +5703,6 @@
     some_pushed = False
     result = 0
     for path in urlutil.get_push_paths(repo, ui, dests):
-        if not path:
-            raise error.ConfigError(
-                _(b'default repository not configured!'),
-                hint=_(b"see 'hg help config.paths'"),
-            )
         dest = path.pushloc or path.loc
         branches = (path.branch, opts.get(b'branch') or [])
         ui.status(_(b'pushing to %s\n') % urlutil.hidepassword(dest))
--- a/mercurial/utils/urlutil.py	Tue Apr 13 15:32:59 2021 +0200
+++ b/mercurial/utils/urlutil.py	Tue Apr 13 15:30:32 2021 +0200
@@ -453,7 +453,10 @@
         elif b'default' in ui.paths:
             yield ui.paths[b'default']
         else:
-            yield None
+            raise error.ConfigError(
+                _(b'default repository not configured!'),
+                hint=_(b"see 'hg help config.paths'"),
+            )
     else:
         for dest in dests:
             yield ui.getpath(dest)
mercurial