Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
util: check fileno() validity in win32 set_binary()
authorPatrick Mezard <pmezard@gmail.com>
Fri, 21 Mar 2008 21:56:55 +0100
changeset 6339 ed9b07a97587
parent 6338 0750f11152fe
child 6340 949e607ac544
util: check fileno() validity in win32 set_binary()
mercurial/util.py file | annotate | diff | comparison | revisions 
--- a/mercurial/util.py	Fri Mar 21 14:52:24 2008 +0100
+++ b/mercurial/util.py	Fri Mar 21 21:56:55 2008 +0100
@@ -1000,7 +1000,9 @@
         pass
 
     def set_binary(fd):
-        if hasattr(fd, 'fileno'):
+        # When run without console, pipes may expose invalid
+        # fileno(), usually set to -1.
+        if hasattr(fd, 'fileno') and fd.fileno() >= 0:
             msvcrt.setmode(fd.fileno(), os.O_BINARY)
 
     def pconvert(path):
mercurial