Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:38:04 +0100
changeset 50614 ecaf00089461
parent 50613 ae2de4cb7869
child 50615 9e69d9d6f4cf
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/url.py file | annotate | diff | comparison | revisions 
--- a/mercurial/url.py	Thu Feb 02 17:37:44 2023 +0100
+++ b/mercurial/url.py	Thu Feb 02 17:38:04 2023 +0100
@@ -190,7 +190,7 @@
     return _sendfile
 
 
-has_https = util.safehasattr(urlreq, b'httpshandler')
+has_https = util.safehasattr(urlreq, 'httpshandler')
 
 
 class httpconnection(keepalive.HTTPConnection):
mercurial