Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:38:14 +0100
changeset 50615 9e69d9d6f4cf
parent 50614 ecaf00089461
child 50616 7200a9d4ea04
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/utils/urlutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/utils/urlutil.py	Thu Feb 02 17:38:04 2023 +0100
+++ b/mercurial/utils/urlutil.py	Thu Feb 02 17:38:14 2023 +0100
@@ -233,7 +233,7 @@
         self.path = path
 
         # leave the query string escaped
-        for a in (b'user', b'passwd', b'host', b'port', b'path', b'fragment'):
+        for a in ('user', 'passwd', 'host', 'port', 'path', 'fragment'):
             v = getattr(self, a)
             if v is not None:
                 setattr(self, a, urlreq.unquote(v))
mercurial