test-pathencode: randomize length of each path component This makes it possible for long and short components to exist in the same path. This also makes shorter path components more likely. For randint(1, randint(1, n)), the likelihood that one sees a number k (1 <= k <= n) is 1/n * (\sum_{k=i}^n 1/i). This decreases with k, much like in the real world where shorter paths are more common than longer ones. The previous fix and this one together cause issue3958 to be detected by this test with reasonable frequency. When this test was run 100 times in a loop, the issue was detected 30 of those times.

--- a/tests/test-pathencode.py	Wed Jun 19 23:01:22 2013 -0700
+++ b/tests/test-pathencode.py	Wed Jun 19 23:05:40 2013 -0700
@@ -125,7 +125,8 @@
     p = pickfrom(rng, firsttable)(rng)
     l = len(p)
     ps = [p]
-    while l < k:
+    maxl = rng.randint(1, k)
+    while l < maxl:
         p = pickfrom(rng, resttable)(rng)
         l += len(p)
         ps.append(p)