Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pytype: stop excluding webcommands.py
authorMatt Harbison <matt_harbison@yahoo.com>
Mon, 13 Dec 2021 22:46:43 -0500
changeset 48485 ea13dabbe168
parent 48484 8a075b679918
child 48486 7caaefa48794
pytype: stop excluding webcommands.py I have no idea why, but asserting that each value added to `emptydirs` is not None didn't fix this: File "/mnt/c/Users/Matt/hg/mercurial/hgweb/webcommands.py", line 621, in dirlist: Function bytes.join was called with the wrong arguments [wrong-arg-types] Expected: (self, iterable: Iterable[bytes]) Actually passed: (self, iterable: List[None]) Differential Revision: https://phab.mercurial-scm.org/D11924
mercurial/hgweb/webcommands.py file | annotate | diff | comparison | revisions
tests/test-check-pytype.t file | annotate | diff | comparison | revisions 
--- a/mercurial/hgweb/webcommands.py	Mon Dec 13 20:45:31 2021 -0500
+++ b/mercurial/hgweb/webcommands.py	Mon Dec 13 22:46:43 2021 -0500
@@ -519,6 +519,7 @@
 
 
 def decodepath(path):
+    # type: (bytes) -> bytes
     """Hook for mapping a path in the repository to a path in the
     working copy.
 
@@ -616,7 +617,9 @@
             yield {
                 b"parity": next(parity),
                 b"path": path,
+                # pytype: disable=wrong-arg-types
                 b"emptydirs": b"/".join(emptydirs),
+                # pytype: enable=wrong-arg-types
                 b"basename": d,
             }
 
--- a/tests/test-check-pytype.t	Mon Dec 13 20:45:31 2021 -0500
+++ b/tests/test-check-pytype.t	Mon Dec 13 22:46:43 2021 -0500
@@ -18,7 +18,6 @@
 mercurial/exchange.py         # [attribute-error]
 mercurial/hgweb/hgweb_mod.py  # [attribute-error], [name-error], [wrong-arg-types]
 mercurial/hgweb/server.py     # [attribute-error], [name-error], [module-attr]
-mercurial/hgweb/webcommands.py  # [missing-parameter]
 mercurial/hgweb/wsgicgi.py    # confused values in os.environ
 mercurial/httppeer.py         # [attribute-error], [wrong-arg-types]
 mercurial/interfaces          # No attribute 'capabilities' on peer [attribute-error]
@@ -55,7 +54,6 @@
   >    -x mercurial/exchange.py \
   >    -x mercurial/hgweb/hgweb_mod.py \
   >    -x mercurial/hgweb/server.py \
-  >    -x mercurial/hgweb/webcommands.py \
   >    -x mercurial/hgweb/wsgicgi.py \
   >    -x mercurial/httppeer.py \
   >    -x mercurial/interfaces \
mercurial