typing: add some assertions that a variable isn't None
authorMatt Harbison <matt_harbison@yahoo.com>
Thu, 05 Jan 2023 17:15:27 -0500
changeset 49853 e63ab79b2fa1
parent 49852 564d360fc98e
child 49854 cb3918e5bc77
typing: add some assertions that a variable isn't None In the case of blackbox, there's a default limit if one isn't explicitly supplied. For the monotone regex, neither group is optional, so a match means it's not None.
hgext/blackbox.py
hgext/convert/monotone.py
--- a/hgext/blackbox.py	Thu Jan 05 17:09:41 2023 -0500
+++ b/hgext/blackbox.py	Thu Jan 05 17:15:27 2023 -0500
@@ -217,6 +217,8 @@
         return
 
     limit = opts.get('limit')
+    assert limit is not None  # help pytype
+
     fp = repo.vfs(b'blackbox.log', b'r')
     lines = fp.read().split(b'\n')
 
--- a/hgext/convert/monotone.py	Thu Jan 05 17:09:41 2023 -0500
+++ b/hgext/convert/monotone.py	Thu Jan 05 17:15:27 2023 -0500
@@ -243,6 +243,7 @@
             m = self.cert_re.match(e)
             if m:
                 name, value = m.groups()
+                assert value is not None  # help pytype
                 value = value.replace(br'\"', b'"')
                 value = value.replace(br'\\', b'\\')
                 certs[name] = value