branchmap: display filtername when `updatebranch` fails to do its jobs
authorPierre-Yves David <pierre-yves.david@ens-lyon.org>
Sat, 19 Jan 2013 02:29:56 +0100
changeset 18451 d6b3b36f1db2
parent 18450 4f9a52858512
child 18452 8bd338c7c4c9
branchmap: display filtername when `updatebranch` fails to do its jobs We have a very handy assert at the ends of `branchmap.updatecache` that check the resulting branchmap is actually valid. I know we do not like assert in mercurial but this one is very handy for debugging. There is really not reason for `branchmap.updatecache` to have this kind of issue but this happened and handful of time during the development of this or introduction of other related feature. I advice to keep it around until we are a bit more confident with the new code.
mercurial/branchmap.py
--- a/mercurial/branchmap.py	Fri Jan 18 01:24:29 2013 +0100
+++ b/mercurial/branchmap.py	Sat Jan 19 02:29:56 2013 +0100
@@ -79,7 +79,7 @@
     if revs:
         partial.update(repo, revs)
         partial.write(repo)
-    assert partial.validfor(repo)
+    assert partial.validfor(repo), filtername
     repo._branchcaches[repo.filtername] = partial
 
 class branchcache(dict):