getgraphlogrevs: remove user of baseset.append
authorPierre-Yves David <pierre-yves.david@fb.com>
Tue, 07 Oct 2014 00:20:00 -0700
changeset 22807 cd43195ef876
parent 22806 65ccc733d58e
child 22808 228b0aafb1ce
getgraphlogrevs: remove user of baseset.append A `baseset` has multiple cached results and will get even more in the future. Making it an object "populated once" like the other smartsets makes it both safer and simpler. The append method will be removed at some point.
mercurial/cmdutil.py
--- a/mercurial/cmdutil.py	Tue Oct 07 00:04:16 2014 -0700
+++ b/mercurial/cmdutil.py	Tue Oct 07 00:20:00 2014 -0700
@@ -1856,12 +1856,12 @@
         revs = matcher(repo, revs)
         revs.sort(reverse=True)
     if limit is not None:
-        limitedrevs = revset.baseset()
+        limitedrevs = []
         for idx, rev in enumerate(revs):
             if idx >= limit:
                 break
             limitedrevs.append(rev)
-        revs = limitedrevs
+        revs = revset.baseset(limitedrevs)
 
     return revs, expr, filematcher