# HG changeset patch # User Pierre-Yves David # Date 1412666400 25200 # Node ID cd43195ef87616477e22a6cbd7ac81caad8c0031 # Parent 65ccc733d58eeea36e67ce2afc5fa1ce67812ef6 getgraphlogrevs: remove user of baseset.append A `baseset` has multiple cached results and will get even more in the future. Making it an object "populated once" like the other smartsets makes it both safer and simpler. The append method will be removed at some point. diff -r 65ccc733d58e -r cd43195ef876 mercurial/cmdutil.py --- a/mercurial/cmdutil.py Tue Oct 07 00:04:16 2014 -0700 +++ b/mercurial/cmdutil.py Tue Oct 07 00:20:00 2014 -0700 @@ -1856,12 +1856,12 @@ revs = matcher(repo, revs) revs.sort(reverse=True) if limit is not None: - limitedrevs = revset.baseset() + limitedrevs = [] for idx, rev in enumerate(revs): if idx >= limit: break limitedrevs.append(rev) - revs = limitedrevs + revs = revset.baseset(limitedrevs) return revs, expr, filematcher