Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
match: remove a mutable default argument
authorPierre-Yves David <pierre-yves.david@fb.com>
Thu, 24 Sep 2015 01:00:25 -0700
changeset 26327 c786dd6cae57
parent 26326 58218b0e6005
child 26328 188c1e9506f5
match: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs.
mercurial/scmutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/scmutil.py	Thu Sep 24 01:00:05 2015 -0700
+++ b/mercurial/scmutil.py	Thu Sep 24 01:00:25 2015 -0700
@@ -778,7 +778,7 @@
         pats = []
     return m, pats
 
-def match(ctx, pats=[], opts={}, globbed=False, default='relpath', badfn=None):
+def match(ctx, pats=(), opts={}, globbed=False, default='relpath', badfn=None):
     '''Return a matcher that will warn about bad matches.'''
     return matchandpats(ctx, pats, opts, globbed, default, badfn=badfn)[0]
mercurial