Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
localrepo.status: move fixup concatenation inside if block for clarity
authorNicolas Dumazet <nicdumz.commits@gmail.com>
Sun, 25 Jul 2010 10:05:38 +0900
changeset 11669 c47cb3193c53
parent 11668 f070d284994c
child 11670 1b3b843e1100
localrepo.status: move fixup concatenation inside if block for clarity clean += fixup only makes sense if fixup is not empty; it should be inside the "if fixup" test.
mercurial/localrepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/localrepo.py	Sat Jul 24 17:23:08 2010 +0200
+++ b/mercurial/localrepo.py	Sun Jul 25 10:05:38 2010 +0900
@@ -1064,11 +1064,11 @@
                     else:
                         fixup.append(f)
 
-                if listclean:
-                    clean += fixup
-
                 # update dirstate for files that are actually clean
                 if fixup:
+                    if listclean:
+                        clean += fixup
+
                     try:
                         # updating the dirstate is optional
                         # so we don't wait on the lock
mercurial