Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
parsers: set exception when there's too little string data to extract parents
authorAugie Fackler <augie@google.com>
Tue, 18 Aug 2015 16:40:10 -0400
changeset 26052 b970418bbafe
parent 26051 af090796cb33
child 26053 b68c9d232db6
parsers: set exception when there's too little string data to extract parents Previously we were returning NULL from this function without actually setting up an exception. This fixes that problem, which was detected with cpychecker.
mercurial/parsers.c file | annotate | diff | comparison | revisions 
--- a/mercurial/parsers.c	Tue Aug 18 16:39:26 2015 -0400
+++ b/mercurial/parsers.c	Tue Aug 18 16:40:10 2015 -0400
@@ -481,8 +481,11 @@
 	len = readlen;
 
 	/* read parents */
-	if (len < 40)
+	if (len < 40) {
+		PyErr_SetString(
+			PyExc_ValueError, "too little data for parents");
 		goto quit;
+	}
 
 	parents = Py_BuildValue("s#s#", str, 20, str + 20, 20);
 	if (!parents)
mercurial