Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
scmutil: use a tuple of possible values instead of using startswith()
authorPulkit Goyal <7895pulkit@gmail.com>
Tue, 26 Dec 2017 22:56:07 +0530
changeset 35499 b55a142f00c5
parent 35498 dfaf9f10e2e5
child 35500 87918218da70
scmutil: use a tuple of possible values instead of using startswith() This patch also adds a review comment which is helpful as inline comment. Differential Revision: https://phab.mercurial-scm.org/D1761
mercurial/scmutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/scmutil.py	Mon Dec 25 22:56:59 2017 +0900
+++ b/mercurial/scmutil.py	Tue Dec 26 22:56:07 2017 +0530
@@ -1319,7 +1319,7 @@
                                                      'directaccess'):
         return repo
 
-    if not repo.filtername.startswith('visible'):
+    if repo.filtername not in ('visible', 'visible-hidden'):
         return repo
 
     symbols = set()
@@ -1345,6 +1345,8 @@
         repo.ui.warn(_("warning: accessing hidden changesets for write "
                        "operation: %s\n") % revstr)
 
+    # we have to use new filtername to separate branch/tags cache until we can
+    # disbale these cache when revisions are dynamically pinned.
     return repo.filtered('visible-hidden', revs)
 
 def _getrevsfromsymbols(repo, symbols):
mercurial