Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: single check for Python keywords used as a function
authorThomas Arendsen Hein <thomas@jtah.de>
Fri, 03 Dec 2010 12:04:31 +0100
changeset 13076 a861c7155f09
parent 13075 d73c3034deee
child 13077 6b8d2ee24ce2
check-code: single check for Python keywords used as a function This replaces the specific checks for del/and/or/not/except and additionally checks other Python keywords.
contrib/check-code.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Fri Dec 03 11:30:45 2010 +0100
+++ b/contrib/check-code.py	Fri Dec 03 12:04:31 2010 +0100
@@ -119,11 +119,8 @@
     (r'^\s*(if|while|def|class|except|try)\s[^[]*:\s*[^\]#\s]+',
      "linebreak after :"),
     (r'class\s[^(]:', "old-style class, use class foo(object)"),
-    (r'^\s+del\(', "del isn't a function"),
-    (r'\band\(', "and isn't a function"),
-    (r'\bor\(', "or isn't a function"),
-    (r'\bnot\(', "not isn't a function"),
-    (r'^\s+except\(', "except isn't a function"),
+    (r'\b(%s)\(' % '|'.join(keyword.kwlist),
+     "Python keyword is not a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
 #     "don't capitalize non-exception classes"),
mercurial