tags: drop nested function
authorMatt Mackall <mpm@selenic.com>
Thu, 18 Jun 2009 23:08:33 -0500
changeset 8854 980f5b7c5fb6
parent 8853 e28b7939d430
child 8855 f331de880cbb
tags: drop nested function
mercurial/localrepo.py
--- a/mercurial/localrepo.py	Thu Jun 18 23:04:54 2009 -0500
+++ b/mercurial/localrepo.py	Thu Jun 18 23:08:33 2009 -0500
@@ -290,26 +290,24 @@
                 globaltags[k] = an, ah
                 tagtypes[k] = tagtype
 
-        def tagctxs():
-            seen = set()
-            f = None
-            ret = []
-            for node in self.heads():
-                try:
-                    fnode = self[node].filenode('.hgtags')
-                except error.LookupError:
-                    continue
-                if fnode not in seen:
-                    seen.add(fnode)
-                    if not f:
-                        f = self.filectx('.hgtags', fileid=fnode)
-                    else:
-                        f = f.filectx(fnode)
-                    ret.append(f)
-            return reversed(ret)
+        seen = set()
+        f = None
+        ctxs = []
+        for node in self.heads():
+            try:
+                fnode = self[node].filenode('.hgtags')
+            except error.LookupError:
+                continue
+            if fnode not in seen:
+                seen.add(fnode)
+                if not f:
+                    f = self.filectx('.hgtags', fileid=fnode)
+                else:
+                    f = f.filectx(fnode)
+                ctxs.append(f)
 
         # read the tags file from each head, ending with the tip
-        for f in tagctxs():
+        for f in reversed(ctxs):
             readtags(f.data().splitlines(), f, "global")
 
         try: