Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:37:58 +0100
changeset 50568 82ef5410f2aa
parent 50567 2452843baf90
child 50569 fca08dd6223d
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/templateutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/templateutil.py	Thu Feb 02 17:23:31 2023 +0100
+++ b/mercurial/templateutil.py	Thu Feb 02 17:37:58 2023 +0100
@@ -868,7 +868,7 @@
                 yield i
             elif i is None:
                 pass
-            elif not util.safehasattr(i, b'__iter__'):
+            elif not util.safehasattr(i, '__iter__'):
                 yield pycompat.bytestr(i)
             else:
                 for j in flatten(context, mapping, i):
mercurial