Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pathencode: check result of .digest() method in sha1hash
authorAugie Fackler <augie@google.com>
Tue, 18 Aug 2015 16:32:41 -0400
changeset 26050 822f46b80fa9
parent 26049 b1634b7804c7
child 26051 af090796cb33
pathencode: check result of .digest() method in sha1hash Without this it was theoretically possible .digest() would fail and return NULL but we wouldn't notice. Detected with cpychecker.
mercurial/pathencode.c file | annotate | diff | comparison | revisions 
--- a/mercurial/pathencode.c	Tue Aug 18 16:43:26 2015 -0400
+++ b/mercurial/pathencode.c	Tue Aug 18 16:32:41 2015 -0400
@@ -684,6 +684,8 @@
 
 	hashobj = PyObject_CallMethod(shaobj, "digest", "");
 	Py_DECREF(shaobj);
+	if (hashobj == NULL)
+		return -1;
 
 	if (!PyString_Check(hashobj) || PyString_GET_SIZE(hashobj) != 20) {
 		PyErr_SetString(PyExc_TypeError,
mercurial