Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
cmdutil: avoid recycling variable name "name" in namespaces code
authorNathaniel Manista <nathaniel@google.com>
Thu, 14 Apr 2016 15:26:18 -0400
changeset 28904 80be5dbe6e74
parent 28903 e1dd0de26557
child 28905 c969c72d6cbc
cmdutil: avoid recycling variable name "name" in namespaces code This just feels like asking for future trouble and confusion.
mercurial/cmdutil.py file | annotate | diff | comparison | revisions 
--- a/mercurial/cmdutil.py	Tue Apr 05 06:53:33 2016 +0200
+++ b/mercurial/cmdutil.py	Thu Apr 14 15:26:18 2016 -0400
@@ -1275,10 +1275,10 @@
             self.ui.write(_("branch:      %s\n") % branch,
                           label='log.branch')
 
-        for name, ns in self.repo.names.iteritems():
+        for nsname, ns in self.repo.names.iteritems():
             # branches has special logic already handled above, so here we just
             # skip it
-            if name == 'branches':
+            if nsname == 'branches':
                 continue
             # we will use the templatename as the color name since those two
             # should be the same
mercurial