Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:35:31 +0100
changeset 50598 80b37d26097f
parent 50597 aea55f2a48b3
child 50599 921a72735482
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/smartset.py file | annotate | diff | comparison | revisions 
--- a/mercurial/smartset.py	Thu Feb 02 17:35:09 2023 +0100
+++ b/mercurial/smartset.py	Thu Feb 02 17:35:31 2023 +0100
@@ -668,7 +668,7 @@
         # try to use our own fast iterator if it exists
         self._trysetasclist()
         if self._ascending:
-            attr = b'fastasc'
+            attr = 'fastasc'
         else:
             attr = b'fastdesc'
         it = getattr(self, attr)
mercurial