rust-dirstatemap: add missing @propertycache stable 5.3
authorRaphaël Gomès <rgomes@octobus.net>
Wed, 29 Jan 2020 11:11:18 +0100
branchstable
changeset 44227 7f5410dfc8a6
parent 44226 cb52e619c99e
child 44228 3ef4b8114b35
rust-dirstatemap: add missing @propertycache While investigating a regression on `hg update` performance introduced by the Rust `dirstatemap`, two missing `@propertycache` were identified when comparing against the Python implementation. This adds back the first one, that has no observable impact on behavior. The second one (`nonnormalset`) is going to be more involved, as the caching has to be done from the Rust side of things. Differential Revision: https://phab.mercurial-scm.org/D8047
mercurial/dirstate.py
--- a/mercurial/dirstate.py	Thu Jan 30 19:16:12 2020 +0100
+++ b/mercurial/dirstate.py	Wed Jan 29 11:11:18 2020 +0100
@@ -1849,7 +1849,7 @@
             nonnorm, otherparents = self._rustmap.nonnormalentries()
             return nonnorm
 
-        @property
+        @propertycache
         def otherparentset(self):
             nonnorm, otherparents = self._rustmap.nonnormalentries()
             return otherparents