Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
run-tests: allow spaces in the --view tool
authorMatt Harbison <matt_harbison@yahoo.com>
Tue, 05 Feb 2019 13:30:48 -0500
changeset 41586 7855a949b7c2
parent 41585 549af2fa089f
child 41587 ccaa52865fac
run-tests: allow spaces in the --view tool Most tools on Windows are in Program Files, and not necessarily on PATH.
tests/run-tests.py file | annotate | diff | comparison | revisions 
--- a/tests/run-tests.py	Tue Feb 05 09:37:23 2019 -0500
+++ b/tests/run-tests.py	Tue Feb 05 13:30:48 2019 -0500
@@ -1902,8 +1902,9 @@
                 pass
             elif self._options.view:
                 v = self._options.view
-                os.system(r"%s %s %s" %
-                          (v, _strpath(test.refpath), _strpath(test.errpath)))
+                subprocess.call(r'"%s" "%s" "%s"' %
+                                (v, _strpath(test.refpath),
+                                 _strpath(test.errpath)), shell=True)
             else:
                 servefail, lines = getdiff(expected, got,
                                            test.refpath, test.errpath)
mercurial