Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
chgserver: document why we don't merge mtimehash and confighash
authorJun Wu <quark@fb.com>
Wed, 29 Jun 2016 23:53:20 +0100
changeset 29462 71ed5a3ef8a9
parent 29461 7d88fde2309f
child 29463 4cf0542dcbe7
chgserver: document why we don't merge mtimehash and confighash People may get confused about chg's mtimehash and confighash design: why two hashes instead of just one. This patch adds text addressing the concern.
hgext/chgserver.py file | annotate | diff | comparison | revisions 
--- a/hgext/chgserver.py	Thu Jun 30 10:31:50 2016 +0100
+++ b/hgext/chgserver.py	Wed Jun 29 23:53:20 2016 +0100
@@ -154,6 +154,10 @@
 
     for chgserver, it is designed that once mtimehash changes, the server is
     considered outdated immediately and should no longer provide service.
+
+    mtimehash is not included in confighash because we only know the paths of
+    extensions after importing them (there is imp.find_module but that faces
+    race conditions). We need to calculate confighash without importing.
     """
     def trystat(path):
         try:
mercurial