Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
audit: reject paths with .hg (issue 1450)
authorMatt Mackall <mpm@selenic.com>
Wed, 31 Dec 2008 16:27:20 -0600
changeset 7553 71be8688f2db
parent 7548 e8b818029ed6
child 7554 11a4eb81fb4f
audit: reject paths with .hg (issue 1450) Spotted by Peter Arrenbrecht
mercurial/util.py file | annotate | diff | comparison | revisions 
--- a/mercurial/util.py	Wed Dec 31 14:21:00 2008 +0100
+++ b/mercurial/util.py	Wed Dec 31 16:27:20 2008 -0600
@@ -814,9 +814,15 @@
             return
         normpath = os.path.normcase(path)
         parts = splitpath(normpath)
-        if (os.path.splitdrive(path)[0] or parts[0] in ('.hg', '')
+        if (os.path.splitdrive(path)[0] or parts[0] in ('.hg', '.hg.', '')
             or os.pardir in parts):
             raise Abort(_("path contains illegal component: %s") % path)
+        if '.hg' in path:
+            for p in '.hg', '.hg.':
+                if p in parts[1:-1]:
+                    pos = parts.index(p)
+                    base = os.path.join(*parts[:pos])
+                    raise Abort(_('path %r is inside repo %r') % (path, base))
         def check(prefix):
             curpath = os.path.join(self.root, prefix)
             try:
mercurial