Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:27:22 +0100
changeset 50577 6be6406a2988
parent 50576 3b642b384b14
child 50578 eb49f8fb11d8
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/hgweb/server.py file | annotate | diff | comparison | revisions 
--- a/mercurial/hgweb/server.py	Thu Feb 02 17:27:06 2023 +0100
+++ b/mercurial/hgweb/server.py	Thu Feb 02 17:27:22 2023 +0100
@@ -100,7 +100,7 @@
 
     def log_request(self, code='-', size='-'):
         xheaders = []
-        if util.safehasattr(self, b'headers'):
+        if util.safehasattr(self, 'headers'):
             xheaders = [
                 h for h in self.headers.items() if h[0].startswith('x-')
             ]
mercurial