Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
util: document we want Python type mapping to be temporary
authorGregory Szorc <gregory.szorc@gmail.com>
Sat, 08 Oct 2016 19:16:50 +0200
changeset 30092 67b0484c9ce4
parent 30091 d576b7394646
child 30093 68010ed1636d
util: document we want Python type mapping to be temporary I think remapping Python C API types and functions is not a great approach. I'd prefer this whole #ifdef disappeared. Add a comment so we don't forget about it.
mercurial/util.h file | annotate | diff | comparison | revisions 
--- a/mercurial/util.h	Sat Oct 08 19:02:44 2016 +0200
+++ b/mercurial/util.h	Sat Oct 08 19:16:50 2016 +0200
@@ -13,6 +13,9 @@
 #if PY_MAJOR_VERSION >= 3
 
 #define IS_PY3K
+/* The mapping of Python types is meant to be temporary to get Python
+ * 3 to compile. We should remove this once Python 3 support is fully
+ * supported and proper types are used in the extensions themselves. */
 #define PyInt_Type PyLong_Type
 #define PyInt_FromLong PyLong_FromLong
 #define PyInt_AsLong PyLong_AsLong
mercurial