revert: move prefetch to after the actions logic stable
authorDurham Goode <durham@fb.com>
Tue, 27 Jan 2015 19:52:26 -0800
branchstable
changeset 23965 6156edaa82aa
parent 23964 f1c127df7c4f
child 23966 2d2c0a8eeeb8
revert: move prefetch to after the actions logic The prefetch logic came before the actual population of the actions collection, so it was always being passed an empty action list. This fixes it by moving it to after that logic. The only consumer of this function at the moment is remotefilelog, and I verified it works with this change.
mercurial/cmdutil.py
--- a/mercurial/cmdutil.py	Wed Jan 28 13:34:20 2015 -0500
+++ b/mercurial/cmdutil.py	Tue Jan 27 19:52:26 2015 -0800
@@ -2765,9 +2765,6 @@
             (unknown,       actions['unknown'],  discard),
             )
 
-        needdata = ('revert', 'add', 'undelete')
-        _revertprefetch(repo, ctx, *[actions[name][0] for name in needdata])
-
         wctx = repo[None]
         for abs, (rel, exact) in sorted(names.items()):
             # target file to be touch on disk (relative to cwd)
@@ -2797,6 +2794,9 @@
 
 
         if not opts.get('dry_run'):
+            needdata = ('revert', 'add', 'undelete')
+            _revertprefetch(repo, ctx, *[actions[name][0] for name in needdata])
+
             _performrevert(repo, parents, ctx, actions)
 
             # get the list of subrepos that must be reverted