Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:29:39 +0100
changeset 50586 58e58ea3dcb8
parent 50585 2d9ba65a4d0a
child 50587 5586076b8030
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/localrepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/localrepo.py	Thu Feb 02 17:28:40 2023 +0100
+++ b/mercurial/localrepo.py	Thu Feb 02 17:29:39 2023 +0100
@@ -1567,7 +1567,7 @@
         def checksvfs(path, mode=None):
             ret = origfunc(path, mode=mode)
             repo = rref()
-            if repo is None or not util.safehasattr(repo, b'_lockref'):
+            if repo is None or not util.safehasattr(repo, '_lockref'):
                 return
             if mode in (None, b'r', b'rb'):
                 return
mercurial