Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
remove unnecessary list comprehensions
authorMartin Geisler <mg@aragost.com>
Thu, 03 Feb 2011 10:31:17 +0100
changeset 13412 58c497d0e44d
parent 13411 d4de90a612f7
child 13413 fa921dcd9993
remove unnecessary list comprehensions These result lists were only built for the side effects, and so a normal loop is just as good and more straight-forward.
mercurial/context.py file | annotate | diff | comparison | revisions
mercurial/ignore.py file | annotate | diff | comparison | revisions
mercurial/localrepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/context.py	Tue Feb 15 22:25:48 2011 +0100
+++ b/mercurial/context.py	Thu Feb 03 10:31:17 2011 +0100
@@ -722,7 +722,8 @@
 
     def tags(self):
         t = []
-        [t.extend(p.tags()) for p in self.parents()]
+        for p in self.parents():
+            t.extend(p.tags())
         return t
 
     def children(self):
--- a/mercurial/ignore.py	Tue Feb 15 22:25:48 2011 +0100
+++ b/mercurial/ignore.py	Thu Feb 03 10:31:17 2011 +0100
@@ -86,7 +86,8 @@
                      (f, inst.strerror))
 
     allpats = []
-    [allpats.extend(patlist) for patlist in pats.values()]
+    for patlist in pats.values():
+        allpats.extend(patlist)
     if not allpats:
         return util.never
 
--- a/mercurial/localrepo.py	Tue Feb 15 22:25:48 2011 +0100
+++ b/mercurial/localrepo.py	Thu Feb 03 10:31:17 2011 +0100
@@ -1242,7 +1242,8 @@
                     self.ui.status(_("skipping missing subrepository: %s\n")
                                    % subpath)
 
-        [l.sort() for l in r]
+        for l in r:
+            l.sort()
         return r
 
     def heads(self, start=None):
mercurial