Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:30:18 +0100
changeset 50587 5586076b8030
parent 50586 58e58ea3dcb8
child 50588 0ec94359eae8
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/lock.py file | annotate | diff | comparison | revisions 
--- a/mercurial/lock.py	Thu Feb 02 17:29:39 2023 +0100
+++ b/mercurial/lock.py	Thu Feb 02 17:30:18 2023 +0100
@@ -76,11 +76,11 @@
         # save handlers first so they can be restored even if a setup is
         # interrupted between signal.signal() and orighandlers[] =.
         for name in [
-            b'CTRL_C_EVENT',
-            b'SIGINT',
-            b'SIGBREAK',
-            b'SIGHUP',
-            b'SIGTERM',
+            'CTRL_C_EVENT',
+            'SIGINT',
+            'SIGBREAK',
+            'SIGHUP',
+            'SIGTERM',
         ]:
             num = getattr(signal, name, None)
             if num and num not in orighandlers:
mercurial