Mercurial Mercurial > mercurial / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rebase: drop unnecessary parentchange call
authorSiddharth Agarwal <sid0@fb.com>
Wed, 31 May 2017 19:46:04 -0700
changeset 32594 517841766994
parent 32593 e4d0b2efb8b5
child 32595 9e46627baa3c
rebase: drop unnecessary parentchange call We're calling localrepo.setparents here, not dirstate.setparents. localrepo.setparents calls dirstate.parentchange already.
hgext/rebase.py file | annotate | diff | comparison | revisions 
--- a/hgext/rebase.py	Tue May 30 13:16:32 2017 -0700
+++ b/hgext/rebase.py	Wed May 31 19:46:04 2017 -0700
@@ -427,8 +427,7 @@
                         mergemod.mergestate.clean(repo)
                 else:
                     # Skip commit if we are collapsing
-                    with repo.dirstate.parentchange():
-                        repo.setparents(repo[p1].node())
+                    repo.setparents(repo[p1].node())
                     newnode = None
                 # Update the state
                 if newnode is not None:
mercurial